Skip to content

Solution for ticket #3353 'Allow explicit undef's for configuration' - #65

Merged
danmar merged 2 commits into
cppcheck-opensource:masterfrom
makulik:master
Nov 30, 2011
Merged

danmar merged 2 commits into
cppcheck-opensource:masterfrom
makulik:master

Conversation

@makulik

@makulik makulik commented Nov 30, 2011

Copy link
Copy Markdown
Contributor

Testcases testpreprocessor.cpp 'undef6' and 'undef7' are still not working as expected, may be someone else can help here. For the background use case I have described in my ticket this solution should work fine though.

Looks all fine to me now! I created a completely new fork of the repo, don't know how to repair the old one :-(. Anyway I've learned some new techniques using GIT when trying to do so ...

…for configuration'

Signed-off-by: makulik <g-makulik@t-online.de>
Signed-off-by: makulik <g-makulik@t-online.de>
danmar pushed a commit that referenced this pull request Nov 30, 2011
Solution for ticket #3353 'Allow explicit undef's for configuration'
@danmar
danmar merged commit 0bf1721 into cppcheck-opensource:master Nov 30, 2011
@danmar

danmar commented Nov 30, 2011

Copy link
Copy Markdown
Collaborator

Thanks for all your trouble and work with this. I had a minor note only.

@makulik

makulik commented Nov 30, 2011

Copy link
Copy Markdown
Contributor Author

De nada! As mentioned I'm also getting more experienced ;-)

Anyway, the two todo testcases undef6 and undef7 leave me a bit dazzled. There's either some flaw in the implementation how the Preprocessor::getcode() expands #else (#elif) code pathes and macro definitions for the default configuration, or I didn't get how it works. To be honest, I have difficulties to understand how the matching_ifdef and matched_ifdef lists work in this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants